lint on states

states/androidstudio/defaults.yaml

@@ -2,4 +2,4 @@
 androidstudio:
   enabled: true
   install_dir: /usr/local/apps
-  config:
+  config: {}

states/dkron/defaults.yaml

@@ -1,21 +1,21 @@
 ---
 dkron:
   enabled: true
-  install_dir: "/usr/local/apps"
-  release_dir: "/usr/local/apps/releases"
-  mirror: "https://github.com/distribworks/dkron/releases/download"
-  version: "3.0.5"
-  os: "linux"
-  arch: "amd64"
-  runuser: "dkron"
-  user: "user"
-  password: "password"
-  url: "http://localhost:8898"
+  install_dir: /usr/local/apps
+  release_dir: /usr/local/apps/releases
+  mirror: https://github.com/distribworks/dkron/releases/download
+  version: 3.0.5
+  os: linux
+  arch: amd64
+  runuser: dkron
+  user: user
+  password: password
+  url: http://localhost:8898
   verify: false
   config:
     bootstrap-expect: 1
     server: true
     ui: true
-    http-addr: "127.0.0.1:8898"
-    data-dir: "/var/lib/dkron"
+    http-addr: 127.0.0.1:8898
+    data-dir: /var/lib/dkron
   jobs_list: []

states/docker/defaults.yaml

@@ -1,8 +1,8 @@
 ---
 docker:
   enabled: true
-  config_dir: "/etc/docker"
-  config_file: "daemon.json"
+  config_dir: /etc/docker
+  config_file: daemon.json
   pkgs:
     - docker-ce
     - docker-ce-cli

states/dovecot/defaults.yaml

@@ -94,8 +94,8 @@ dovecot:
       15-lda.conf:
         hostname: host.example.com
         sendmail_path: /usr/sbin/sendmail
-        lda_mailbox_autocreate: yes
-        lda_mailbox_autosubscribe: yes
+        lda_mailbox_autocreate: 'yes'
+        lda_mailbox_autosubscribe: 'yes'
         protocol lda:
           mail_plugins: $mail_plugins autocreate sieve quota
           postmaster_address: postmaster@example.com

states/drone/defaults.yaml

@@ -1,4 +1,4 @@
 ---
 drone:
   enabled: true
-  server:
+  server: {}

states/netbox/defaults.yaml

@@ -42,7 +42,7 @@ netbox:
         database: 0
         cache_database: 1
         default_timeout: 300
-        ssl: False
+        ssl: false
       caching:
         host: "localhost"
         port: 6379
@@ -50,7 +50,7 @@ netbox:
         database: 0
         cache_database: 1
         default_timeout: 300
-        ssl: False
+        ssl: false
     admins:
       - ['John Doe', 'jdoe@example.com']
       - ['Bob Reptincel', 'breptincel@example.com']
@@ -60,10 +60,10 @@ netbox:
     base_path: ""
     cache_timeout: 900
     changelog_retention: 90
-    cors_origin_allow_all: False
+    cors_origin_allow_all: false
     cors_origin_whitelist: []
     cors_origin_regex_whitelist: []
-    debug: False
+    debug: false
     email:
       server: "localhost"
       port: 25
@@ -71,24 +71,24 @@ netbox:
       password: password
       timeout: 10
       from_email: user@domain.com
-    enforce_global_unique: False
+    enforce_global_unique: false
     exempt_view_permissions: []
     logging: {}
-    login_required: False
+    login_required: false
     login_timeout: 3600
-    maintenance_mode: False
+    maintenance_mode: false
     max_page_size: 1000
-    metrics_enabled: False
+    metrics_enabled: false
     napalm_username: ''
     napalm_password: ''
     napalm_timeout: 30
     napalm_args: {}
     paginate_count: 50
-    prefer_ipv4: False
+    prefer_ipv4: false
     session_file_path: "/tmp"
     session_cookie_age: 3600
     time_zone: "UTC"
-    webhooks_enabled: False
+    webhooks_enabled: false
     date_format: "N j, Y"
     short_date_format: "Y-m-d"
     time_format: "g:i a"

states/nftables/defaults.yaml

@@ -1,4 +1,4 @@
 ---
 nftables:
   enabled: true
-  networks:
+  networks: {}

states/opendkim/defaults.yaml

@@ -9,14 +9,14 @@ opendkim:
     user: opendkim
     group: opendkim
     notify_addr: postmaster@example.com
-    notify_report: yes
+    notify_report: 'yes'
     host: 'localhost'
     port: 8891
-    log_why: yes
+    log_why: 'yes'
     canonicalization: 'relaxed/simple'
-    require_safe_keys: false
-    syslog: yes
-    syslog_success: yes
+    require_safe_keys: 'false'
+    syslog: 'yes'
+    syslog_success: 'yes'
     key:
       name: mx
       content: >

states/pycharm/install.sls

@@ -25,4 +25,3 @@ pycharm-shortcut:
     - user: root
     - group: root
     - mode: 644
-

states/rainloop/config.sls

@@ -1,3 +1 @@
 ---
-rainloop-config:
-

states/redis/defaults.yaml

@@ -1,2 +1,2 @@
 ---
-redis:
+redis: {}

states/salt_minion/defaults.yaml

@@ -4,11 +4,11 @@ salt_minion:
   version: 3000
   config:
     master: salt.paulbsd.com
-    #hash_type: sha256
-    #state_verbose: True
-    #tcp_keepalive: True
-    #tcp_keepalive_idle: 300
-    #random_reauth_delay: 60
-    #recon_default: 1000
-    #recon_max: 10000
-    #recon_randomize: True
+    # hash_type: sha256
+    # state_verbose: True
+    # tcp_keepalive: True
+    # tcp_keepalive_idle: 300
+    # random_reauth_delay: 60
+    # recon_default: 1000
+    # recon_max: 10000
+    # recon_randomize: True

states/salt_minion/service.sls

@@ -12,4 +12,4 @@ salt-minion-service-file:
 salt-minion-service:
   service.running:
     - name: salt-minion
-    - enable: True
+    - enable: true

states/samba/defaults.yaml

@@ -1,4 +1,4 @@
 ---
 samba:
   enabled: true
-  config:
+  config: {}

states/ssh/defaults.yaml

@@ -15,4 +15,4 @@ ssh:
     AllowGroups: admin
     X11Forwarding: 'yes'
   ssh_config:
-    ForwardAgent: yes
+    ForwardAgent: 'yes'

states/sublimetext/install.sls

@@ -54,4 +54,3 @@ sublimetext-desktop-entry:
     - mode: 0644
     - require:
       - archive: sublimetext-extract-archive
-

states/time/defaults.yaml

@@ -2,3 +2,6 @@
 time:
   zone: Europe/Paris
   server: fr.pool.ntp.org
+  pkgs:
+    - ntp
+    - ntpdate

states/time/install.sls

@@ -2,4 +2,4 @@
 {%- from "time/map.jinja" import time with context %}
 time-pkgs:
   pkg.latest:
-    - pkgs: ['ntp', 'ntpdate']
+    - pkgs: {{ time.pkgs }}

states/vsftpd/vsftpd.conf.j2

@@ -1,5 +1,4 @@
 ## {{ salt['pillar.get']('salt_managed', default='Salt Managed') }}
-
 {%- from "vsftpd/map.jinja" import vsftpd with context %}
 
 {%- for key, value in vsftpd.config.items() %}

states/youtubedl/defaults.yaml

@@ -1,4 +1,4 @@
 ---
 youtubedl:
-  install_dir: "/usr/bin"
-  version: "2020.03.24"
+  install_dir: /usr/bin
+  version: 2020.03.24

states/zabbix/defaults.yaml

@@ -22,8 +22,8 @@ zabbix:
     pkgs:
       - python3-pyzabbix
       - zabbix-agent
-      #- zabbix-get
-      #- zabbix-sender
+      # - zabbix-get
+      # - zabbix-sender
     config:
       Hostname: localhost
       Include: "/etc/zabbix/zabbix_agentd.conf.d/*.conf"

states/zsh/defaults.yaml

@@ -1,4 +1,4 @@
 ---
 zsh:
   enabled: true
-  config:
+  config: {}