updated states (lints) / updated .drone.yml

.drone.yml

@@ -10,4 +10,6 @@ steps:
       - apt-get update -y
       - apt-get upgrade -y
       - pip3 install salt-lint
-      - salt-lint states
+      - >
+        'find states -type f -name "*.sls" -print0 |'
+        ' xargs -0 --no-run-if-empty salt-lint'

states/apparmor/init.sls

@@ -8,7 +8,7 @@ apparmor-{{ cfg }}:
     - source: "salt://apparmor/{{ cfg }}.j2"
     - user: root
     - group: root
-    - mode: 0644
+    - mode: "0644"
     - template: jinja
     - watch_in:
       - service: apparmor-reload

states/apt/init.sls

@@ -1,11 +1,11 @@
 ---
 {%- from "apt/map.jinja" import apt with context %}
-{% for k, v in apt.config.items() -%}
-apt-proxy-{{ k }}:
+{% for itemkey, itemvalue in apt.config.items() -%}
+apt-proxy-{{ itemkey }}:
   file.managed:
     - name: /etc/apt/apt.conf.d/{{ k }}
     - user: root
     - group: root
-    - mode: 0644
-    - contents: {{ v.content }}
+    - mode: "0644"
+    - contents: {{ itemvalue.content }}
 {% endfor -%}

states/gufw/init.sls

@@ -2,10 +2,10 @@
 gufw-cfg:
   file.managed:
     - source: salt://gufw/gufw.cfg
-    - name: /etc/gufw/gufw.cfg 
+    - name: /etc/gufw/gufw.cfg
     - user: root
     - group: root
-    - mode: 600
+    - mode: "0600"
 
 gufw-desktop-cfg:
   file.managed:
@@ -13,4 +13,4 @@ gufw-desktop-cfg:
     - name: /etc/gufw/Desktop.profile
     - user: root
     - group: root
-    - mode: 600
+    - mode: "0600"

states/maildb/init.sls

@@ -16,7 +16,7 @@ maildb-apps-dir:
     - name: {{ maildb.appdir }}
     - user: vmail
     - group: vmail
-    - mode: 0755
+    - mode: "0755"
     - makedirs: true
 
 maildb-script:
@@ -25,6 +25,6 @@ maildb-script:
     - source: salt://maildb/maildb.py
     - user: vmail
     - group: vmail
-    - mode: 0755
+    - mode: "0755"
     - require:
       - file: maildb-apps-dir

states/misc/init.sls

@@ -4,15 +4,15 @@ misc-public-dir:
     - name: /home/public
     - user: root
     - group: root
-    - mode: 0755
+    - mode: "0755"
 
 {%- for file in salt['pillar.get']('misc_files') %}
 {{ file.name }}:
   file.managed:
     - name: {{ file.dest }}
-    - source: {{ file.src }} 
-    - source_hash: sha256={{ file.checksum }} 
+    - source: {{ file.src }}
+    - source_hash: sha256={{ file.checksum }}
     - user: root
     - group: root
-    - mode: 644
+    - mode: "0644"
 {%- endfor %}

states/netboxinventory/init.sls

@@ -12,8 +12,6 @@ netbox.create_site_{{ salt['grains.get']('location') }}:
 {%- endif %}
 
 {%- if salt['netbox.get'](app='dcim', endpoint='device-roles', name=salt['grains.get']('type')) == {} %}
-"{{ salt['netbox.get'](app='dcim', endpoint='sites', name='nurnberg')}}"
-"{{ salt['netbox.get'](app='dcim', endpoint='device-roles', name='front')}}"
 netbox.create_device_role_{{ salt['grains.get']('type') }}:
   module.run:
     - name: netbox.create_device_role

states/nextcloud_desktop/init.sls

@@ -8,7 +8,7 @@ nextcloud-desktop-appimage:
     - skip_verify: true
     - user: root
     - group: root
-    - mode: 755
+    - mode: "0755"
     - if_missing: {{ nextcloud_desktop.dest_path }}-{{ nextcloud_desktop.version }}
 
 nextcloud-desktop-install-link:
@@ -25,7 +25,7 @@ nextcloud-desktop-icon:
     - source: salt://nextcloud_desktop/nextcloud.png
     - user: root
     - group: root
-    - mode: 644
+    - mode: "0644"
 
 nextcloud-desktop-icon-entry:
   file.managed:
@@ -33,4 +33,4 @@ nextcloud-desktop-icon-entry:
     - source: salt://nextcloud_desktop/nextcloud.desktop
     - user: root
     - group: root
-    - mode: 644
+    - mode: "0644"

states/tor/init.sls

@@ -10,7 +10,7 @@ tor-config:
     - source: salt://tor/torrc.j2
     - user: root
     - group: root
-    - mode: 0660
+    - mode: "0660"
     - template: jinja
     - watch_in:
       - service: tor-service

states/vsftpd/init.sls

@@ -5,7 +5,7 @@ vsftpd-config:
     - source: salt://vsftpd/vsftpd.conf.j2
     - user: root
     - group: root
-    - mode: 644
+    - mode: "0644"
     - template: jinja
     - watch_in:
       - service: vsftpd-service

states/youtubedl/init.sls

@@ -6,6 +6,6 @@ youtubedl-bin:
     - source: https://github.com/ytdl-org/youtube-dl/releases/download/{{ youtubedl.version }}/youtube-dl
     - user: root
     - group: root
-    - mode: 0775
+    - mode: "0775"
     - template: jinja
     - skip_verify: true

states/ytdlp/init.sls

@@ -6,6 +6,6 @@ ytdlp-bin:
     - source: https://github.com/yt-dlp/yt-dlp/releases/download/{{ ytdlp.version }}/yt-dlp
     - user: root
     - group: root
-    - mode: 0775
+    - mode: "0775"
     - template: jinja
     - skip_verify: true